Add parameter to specify an alternate package name to install #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this? Its a pretty simple change. Should I implement it in a different way? |
| @@ -63,16 +65,17 @@ | |||
| $manage_service = true, | |||
| $enable = true, | |||
| $global_options = $haproxy::params::global_options, | |||
| $defaults_options = $haproxy::params::defaults_options | |||
| $defaults_options = $haproxy::params::defaults_options, | |||
| $pkg_name = 'haproxy' | |||
There was a problem hiding this comment.
Could you make this the full $package_name parameter name instead of a shortened form?
|
Sorry to not see this sooner! I left a comment and will try to check back soon. Feel free to ping me ( |
rharrison10
added a commit
to rharrison10/puppetlabs-haproxy
that referenced
this pull request
Aug 21, 2013
|
I updated my branch with the requested changes. |
rharrison10
added a commit
to rharrison10/puppetlabs-haproxy
that referenced
this pull request
Aug 21, 2013
Change parameter name per comment on pull request puppetlabs#42 puppetlabs#42 (comment)
Change parameter name per comment on pull request puppetlabs#42 puppetlabs#42 (comment)
hunner
added a commit
that referenced
this pull request
Aug 21, 2013
Add parameter to specify an alternate package name to install
cegeka-jenkins
pushed a commit
to cegeka/puppet-haproxy
that referenced
this pull request
Dec 19, 2017
Change parameter name per comment on pull request puppetlabs#42 puppetlabs#42 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have built a haproxy15 package so we can use it for ssl proxy applications. Everything else works with your module so being able to specify the name of the package to install would be very helpful. I'm sure others have similar needs.