Fix 'option' entry name in option_order hash #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `option_order` hash is used to determine the correct order of various backend/listen configuration parameters but it contained a misspelled "options" parameter that is really called "option". This change fixes that and extends the spec tests for the haproxy::listen define to catch this problem. See the discussion in puppetlabs#442 for more details and the reasoning behind the `option_order` hash and why option order is important in HAProxy. Unfortunately the change in puppetlabs#442 also introduced the misspelled parameter and no spec test caught it.
|
Hi @antaflos, thank you for submitting this PR! I hope the problem will be solved this time, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
option_orderhash is used to determine the correct order ofvarious backend/listen configuration parameters but it contained
a misspelled "options" parameter that is really called "option". This
change fixes that and extends the spec tests for the haproxy::listen
define to catch this problem.
See the discussion in #442 for more details and the reasoning behind the
option_orderhash and why option order is important in HAProxy.Unfortunately the change in #442 also introduced the misspelled
parameter and no spec test caught it.