Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAPROXY: Version 2.3.x supports Syslog Protocol (UDP/TCP) #499

Closed
wants to merge 3 commits into from

Conversation

erwindwight
Copy link

We have a use case to migrate our central Syslog servers to be behind haproxy, and we need TCP and UDP backend, so haproxy version 2.3 will help us with our use case.

https://www.haproxy.com/blog/announcing-haproxy-2-3/#syslog-protocol-udp-tcp
https://cbonte.github.io/haproxy-dconv/2.3/configuration.html#3.10

@erwindwight erwindwight requested a review from a team as a code owner September 12, 2021 14:45
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

haproxy::logforward is a type

that may have no external impact to Forge modules.

haproxy::logforward::configure is a class

that may have no external impact to Forge modules.

This module is declared in 40 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link

Hi @erwindwight, just some minor rubocop offenses, do you mind if I fix them and push the changes to your PR? Or you can do it if you want

Copy link
Author

@erwindwight erwindwight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daianamezdrea thank you for the fix.
Didn't have time to work on it earlier, so thanks!

@erwindwight erwindwight marked this pull request as draft September 16, 2021 22:51
@erwindwight erwindwight marked this pull request as ready for review September 19, 2021 09:36
@daianamezdrea
Copy link

Hello @erwindwight, can you add some tests here to provide the functionality ? Thank you and let me know when is ready to be merged, also if you need help or examples I'm here to help. Cheers !

@anthonysomerset
Copy link

i also have a use case for this :) would love to know how i can help with reviewing this and getting it merged

@anthonysomerset
Copy link

i can confirm this is working fine for me

@erwindwight
Copy link
Author

I can confirm this is working fine for me

Hi @anthonysomerset
Thank you for taking the time to check this out.
We have had this working internally in our organization for some time.

This is pending proper unit testing, this is in my task list, but I can't find time to work on this.
Feel free to help on this part, and I would love to see this merge.

@github-actions
Copy link

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label May 10, 2022
@github-actions github-actions bot closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants