Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Add support for Ubuntu 22.04 #528

Merged
merged 2 commits into from
Oct 3, 2022
Merged

(MAINT) Add support for Ubuntu 22.04 #528

merged 2 commits into from
Oct 3, 2022

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Sep 15, 2022

Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported. This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent.

In this commit:

  • Support for Ubuntu 22.04 was added.

The list of supported OSs can be found here:
https://puppet.com/docs/pe/2021.7/supported_operating_systems.html

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner September 15, 2022 08:41
Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported.
This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent.

In this commit:
- Support for Ubuntu 22.04 was added.

The list of supported OSs can be found here:
https://puppet.com/docs/pe/2021.7/supported_operating_systems.html
@jordanbreen28 jordanbreen28 changed the title (MAINT) Refactoring supported OSs based on puppet agent docs (MAINT) Add support for Ubuntu 22.04 Sep 16, 2022
GSPatton
GSPatton previously approved these changes Sep 20, 2022
Copy link

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

metadata.json Outdated
@@ -29,7 +29,7 @@
{
"operatingsystem": "CentOS",
"operatingsystemrelease": [
"7",
"7",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this trailing whitespace?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gavin - I made this change in the latest commit.

@david22swan
Copy link
Member

Adding support for a new OS is a feature

@GSPatton GSPatton merged commit b92c12e into main Oct 3, 2022
@GSPatton GSPatton deleted the maint-os_refactor branch October 3, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants