(CONT-651) Adjusting datatypes #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was an module update that assigned datatypes to all parameters in the module. However, some of these datatypes proved to be either too generic to properly enforce a value or not comprehensive enough to develop proper documentation around it. This commit adjust these datatypes so that they fit better the parameters they define.
haproxy::balancermember is a typeBreaking changes to this file WILL impact these 10 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):haproxy::config is a typethat may have no external impact to Forge modules. haproxy is a classBreaking changes to this file WILL impact these 10 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):haproxy::install is a typethat may have no external impact to Forge modules. haproxy::instance is a typethat may have no external impact to Forge modules. haproxy::mailer is a typethat may have no external impact to Forge modules. haproxy::peer is a typethat may have no external impact to Forge modules. This module is declared in 40 of 580 indexed public
|
LukasAud
changed the title
LukasAud
force-pushed
the
CONT-651-Adjusting_datatypes
branch
from
2e98284
to
348ee20
Compare
david22swan
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was an module update that assigned datatypes to all parameters in the module. However, some of these datatypes proved to be either too generic to properly enforce a value or not comprehensive enough to develop proper documentation around it.
This commit adjust these datatypes so that they fit better the parameters they define.