Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-966) Replace replace .is_hash with .is_a(Hash) #551

Merged
merged 1 commit into from
May 15, 2023

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner May 15, 2023 12:37
@puppet-community-rangefinder
Copy link

haproxy::backend is a type

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 3 modules (near match):

This module is declared in 40 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan changed the title (BugFix) Replace replace .is_hash with .is_a(Hash) (CONT-966) Replace replace .is_hash with .is_a(Hash) May 15, 2023
@david22swan
Copy link
Member Author

Error is unrelated to change and predates the need for this fix: https://github.com/puppetlabs/puppetlabs-haproxy/actions/runs/4931604081/jobs/8820084341

@david22swan
Copy link
Member Author

Failures on RHEL 9 are unrelated to change and predates the need for this fix: https://github.com/puppetlabs/puppetlabs-haproxy/actions/runs/4931604081/jobs/8820084341

Copy link

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
rhel-9 test failures unrelated and present in nightlies.

@jordanbreen28 jordanbreen28 merged commit a26af30 into main May 15, 2023
31 of 33 checks passed
@jordanbreen28 jordanbreen28 deleted the CONT-966/main/is_a(Hash) branch May 15, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants