Allow user-defined service restart parameter. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows, for example, use of /etc/init.d/haproxy reload to restart haproxy when config changes, which: - includes syntax checks - restarts without interruption to service
|
👍 from me, this is a very useful feature to have. It would be even more ideal if the module could differentiate between config changes that require a restart and those that only require a reload, but I don't think this is possible with the way the module currently manages the haproxy configuration. Would probably need to move to an Augeas-based configuration like in https://github.com/rodjek/puppet-haproxy for this to work. |
|
Looks good, 👍 |
apenney
pushed a commit
that referenced
this pull request
Apr 3, 2014
Allow user-defined service restart parameter.
cegeka-jenkins
pushed a commit
to cegeka/puppet-haproxy
that referenced
this pull request
Dec 19, 2017
Allow user-defined service restart parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows, for example, on CentOS/Debian/Ubuntu us to use /etc/init.d/haproxy reload to restart haproxy when config changes, which:
Without this it's easy to push out a option with, say a typo in it, which will cause haproxy to be left in a stopped state with broken config, because /etc/init.d/haproxy restart stops haproxy then starts it.
An alternative way to achieve this would be some logic to set an appropriate restart command for each distro, but I shied away from this, because it would presumably have to take into account things like Fedora's move to systemd.