Moved from #include_class to #contain_class
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed per the DEPRECATION warning [1]. Since this repo does not include a
Gemfile.lock, and the Gemfile does not have version requirements, `bundle`
will install the most recent upstream version of the gems.
I personally suggest adding the Gemfile.lock to the repo. This will guarantee
the exact gem deps are installed on each execution of `bundle`. However, for
now will keep things as is, and simply added a .gitignore.
[1] DEPRECATION: include_class is deprecated. Use contain_class instead. Called from /Users/jodewey/.rvm/gems/ruby-1.9.3-
p484/gems/rspec-puppet-1.0.1/lib/rspec-puppet/matchers/include_class.rb:7:in `block (2 levels) in <module:ManifestMatchers>'.
hunner
added a commit
that referenced
this pull request
Jan 29, 2014
Moved from `#include_class` to `#contain_class`
cegeka-jenkins
pushed a commit
to cegeka/puppet-haproxy
that referenced
this pull request
Dec 19, 2017
Moved from `#include_class` to `#contain_class`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed per the DEPRECATION warning [1]. Since this repo does not include a
Gemfile.lock, and the Gemfile does not have version requirements,
bundlewill install the most recent upstream version of the gems.
I personally suggest adding the Gemfile.lock to the repo. This will guarantee
the exact gem deps are installed on each execution of
bundle. However, fornow will keep things as is, and simply added a .gitignore.