Fix ordering of options changing

[lboynton]

The order of the options kept changing on each puppet run for me. Adding the sort makes the order consistent on each puppet run.

[blkperl]

👍 Looks good

[greg0ire]

Please revert this. I think the order must the one specified in the defined type. See here why. Maybe another solution could be found to make sure this order is preserved?

[lboynton]

The problem with simply reverting the change is that the order can change each time puppet runs, thus resulting in the same warning occurring, albeit not every time. What other options are there for fixing the order?

[greg0ire]

@lboynton : you are right, before reverting this, the underlying bug (having the order change sometimes) should be fixed. Why does it even change? And, more importantly, did you report that bug somewhere?

[greg0ire]

@lboynton : I think I found a bug report about this (since options are passed with a hash). I'm using ruby 1.9, what are you using (or rather, were you using at the time)?

[greg0ire]

ping @lboynton

[greg0ire]

@hunner : any comment on this ? Could you revert this ?

[lboynton]

I was using Ruby 1.8.7, since that is the default with CentOS 6. According to that bug report, there is no fix for Ruby 1.8?

[igalic]

i don't get why this is necessary. both ports and options are arrays, they should be presorted/not change their sort-order. regardless of ruby version.

[greg0ire]

@igalic : you can find an explanation in the bug report I linked previously.
@lboynton : thanks for your answer, and no, there seems to be no fix for Ruby 1.8, and it says the hashes happen to have their sort order preserved in 1.9, but this is not a requirement of the language spec, which means using hashes in puppet is… bug-based. What should be done is something ugly, like in concat (using an "order") :

[
   {'key' => 'use_backend', 'value' => 'some_value', 'order'=> 1},
   {'key' => 'use_backend', 'value' => 'some_value', 'order'=> 2}
]

It would be more sensible IMO to stay "bug-based", but remove the sort so that 1.9 users get the order they choose.