Rewrite with install/config/service classes, and correct parameter naming. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an active/passive scenario, as a user I'd like the configuration to be set and the package to be installed without the service being started. The `if $enable` (l81) prevents this. Today, if one sets `manage_service = true` and `enable = false`, it will result in a catalog compilation issue, due to the `Concat[/etc/haproxy/haproxy.cfg']` dependency on line 134 not being met.
This module needs to follow the BGTM (http://docs.puppetlabs.com/guides/module_guides/bgtm.html#) and this is helping.
This adds basic single node and multi node tests, and will run the different tests depending on which nodeset is chosen. There is no default nodeset yet.
apenney
pushed a commit
that referenced
this pull request
Apr 28, 2014
Rewrite with install/config/service classes, and correct parameter naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class and parameter structure follows http://docs.puppetlabs.com/guides/module_guides/bgtm.html and allows the service to be managed independently from the package, as per #73
It also adds beaker-rspec tests.
Closes #73