Add haproxy::listen bind_options parameter for setting arbitrary 'bind' options #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI build failed under Ruby 1.8.7 on this: /home/travis/.rvm/gems/ree-1.8.7-2012.02/gems/json-1.8.1/lib/json/ext/parser.so: [BUG] Segmentation fault Is this actually a problem with the patch? Not sure how to go about fixing that. |
| @@ -14,7 +14,7 @@ | |||
| it { should contain_concat__fragment('croy_listen_block').with( | |||
| 'order' => '20-croy-00', | |||
| 'target' => '/etc/haproxy/haproxy.cfg', | |||
| 'content' => "\nlisten croy\n bind 1.1.1.1:18140\n balance roundrobin\n option tcplog\n option ssl-hello-chk\n" | |||
| 'content' => "\nlisten croy\n bind 1.1.1.1:18140 \n balance roundrobin\n option tcplog\n option ssl-hello-chk\n" | |||
There was a problem hiding this comment.
Due to the way the haproxy_listen_block.erb template is coded (see below.) There's always a space after the ip:port, even if there are no bind options specified.
hunner
added a commit
that referenced
this pull request
May 19, 2014
Add haproxy::listen bind_options parameter for setting arbitrary 'bind' options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.