Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to replace an existing array with an empty array #105

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix to replace an existing array with an empty array #105

merged 1 commit into from
Feb 25, 2020

Conversation

trevor-vaughan
Copy link
Contributor

  • Added a workaround for a bug in Puppet as demonstrated in HC-99
  • Add key deletion example
    • Update README.md with example of deleting a top-level key
    • Add test as a verification example

HC-99 #close

@carabasdaniel
Copy link

Hi @trevor-vaughan,

Thank you for submitting this PR. These changes look good.

As per https://github.com/puppetlabs/puppetlabs-hocon/blob/master/CONTRIBUTING.md could you please fix the Travis failing tests, change the commit message and the PR title.

@trevor-vaughan
Fix HC-99
dd5647f 
* Added a workaround for a bug in Puppet as demonstrated in HC-99
* Add key deletion example
  * Update README.md with example of deleting a top-level key
  * Add test as a verification example

HC-99 #close
@trevor-vaughan
Copy link
Contributor Author

@carabasdaniel PR updated

@carabasdaniel carabasdaniel changed the title Fix HC-99 [HC-99] Fix to replace an existing array with an empty array Feb 25, 2020
@carabasdaniel carabasdaniel merged commit 3cf2bef into puppetlabs:master Feb 25, 2020
@h0tw1r3 h0tw1r3 changed the title [HC-99] Fix to replace an existing array with an empty array Fix to replace an existing array with an empty array Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
2 participants
@trevor-vaughan @carabasdaniel