-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MAINT) Set up Travis #14
Conversation
Hm, seems like travis is working properly, but it seems like it's failed a couple times on ruby 2.2.0 (it failed once and then I reran it and it failed again).
I get this if I run the tests locally against 2.2.0 too. Should we just merge this and have travis fail? Or comment out 2.2.0 support until we've fixed it? I think I would prefer commenting out 2.2.0, rather than merging and having it be failing. Also, it doesn't seem like this (Travis builds) is currently reporting to HipChat? |
@rlinehan I agree, I'm going to comment out 2.2.0 support. I'll also look into fixing the Hipchat notifications. |
@rlinehan I've removed 2.2.0 support. Also, I added hipchat notifications. |
@rlinehan Okay, hopefully notifications will work this time |
Okay, maybe this time it'll work |
a69a53b
to
5b17452
Compare
👍 Hipchat notifications are maybe not working even though it seems like they should be, so just going to go ahead and merge because maybe they're just not working because this PR has been force pushed so many times? Who knows. |
No description provided.