Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Set up Travis #14

Merged
merged 1 commit into from
May 15, 2015
Merged

(MAINT) Set up Travis #14

merged 1 commit into from
May 15, 2015

Conversation

MSLilah
Copy link
Contributor

@MSLilah MSLilah commented May 11, 2015

No description provided.

@rlinehan
Copy link
Contributor

Hm, seems like travis is working properly, but it seems like it's failed a couple times on ruby 2.2.0 (it failed once and then I reran it and it failed again).

/home/travis/.rvm/gems/ruby-2.2.0/gems/puppet-3.7.5/lib/puppet/vendor/safe_yaml/lib/safe_yaml/syck_node_monkeypatch.rb:42:in `<top (required)>': uninitialized constant Syck (NameError)

    from /home/travis/.rvm/gems/ruby-2.2.0/gems/puppet-3.7.5/lib/puppet/vendor/safe_yaml/lib/safe_yaml.rb:197:in `require'

I get this if I run the tests locally against 2.2.0 too.

Should we just merge this and have travis fail? Or comment out 2.2.0 support until we've fixed it? I think I would prefer commenting out 2.2.0, rather than merging and having it be failing.

Also, it doesn't seem like this (Travis builds) is currently reporting to HipChat?

@MSLilah
Copy link
Contributor Author

MSLilah commented May 12, 2015

@rlinehan I agree, I'm going to comment out 2.2.0 support. I'll also look into fixing the Hipchat notifications.

@MSLilah
Copy link
Contributor Author

MSLilah commented May 12, 2015

@rlinehan I've removed 2.2.0 support. Also, I added hipchat notifications.

@MSLilah
Copy link
Contributor Author

MSLilah commented May 12, 2015

@rlinehan Okay, hopefully notifications will work this time

@MSLilah
Copy link
Contributor Author

MSLilah commented May 13, 2015

Okay, maybe this time it'll work

@MSLilah MSLilah force-pushed the maint/travis branch 10 times, most recently from a69a53b to 5b17452 Compare May 14, 2015 23:31
@rlinehan
Copy link
Contributor

👍 Hipchat notifications are maybe not working even though it seems like they should be, so just going to go ahead and merge because maybe they're just not working because this PR has been force pushed so many times? Who knows.

rlinehan added a commit that referenced this pull request May 15, 2015
@rlinehan rlinehan merged commit 1a760ba into puppetlabs:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants