Remove unnecessary hocon require, add write_conf method #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we had a separate config_saver module for saving the hocon config to disk. This module was requiring the hocon gem without Puppet feature protection. This was causing requirement issues on the Puppet Server side, where the hocon gem is not typically installed. This commit moves the code from config saver into the main hocon provider, as the method write_conf. This removes the unnecessary require, and cleans up the unnecessary config_saver module.
|
Looks good to me assuming travis passes. |
|
Whenever that happens. |
|
@jpinsonault CI passed. :) |
|
Since it's such a simple change I'll go ahead and merge it. Mentioning @fpringvaldsen because he will want to know the PR exists I'm sure |
jpinsonault
added a commit
that referenced
this pull request
Jun 22, 2015
Remove unnecessary hocon require, add write_conf method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we had a separate config_saver module
for saving the hocon config to disk. This module was requiring
the hocon gem without Puppet feature protection. This was causing
requirement issues on the Puppet Server side, where the hocon gem
is not typically installed.
This commit moves the code from config saver into the main hocon
provider, as the method write_conf. This removes the unnecessary
require, and cleans up the unnecessary config_saver module.