(HC-33) Support adding element when array does not exist yet #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior for applying an `array_element` when the array does not exist in the target file yet from displaying an error to creating the array and populating it with the element.
| "foo" : "foovalue3" | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Some of the whitespace behavior here seems really bizarre to me, but I assume that's controlled by logic in the hocon gem - nothing that the Puppet module can do to avoid it.
There was a problem hiding this comment.
@camlow325 That's correct, the whitespace behavior is controlled entirely by the hocon gem. It definitely seems weird to me that there seem to be some extra newlines being generated, so maybe there are some improvements that need to be made there.
|
Ping @nwolfe and @fpringvaldsen for review. |
|
👍 |
1 similar comment
|
👍 |
nwolfe
added a commit
that referenced
this pull request
Oct 31, 2015
…ent-when-not-already-in-target (HC-33) Support adding element when array does not exist yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior for applying an
array_elementwhenthe array does not exist in the target file yet from displaying an error
to creating the array and populating it with the element.