Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HC-46) Confine provider based on hocon feature #28

Merged

Conversation

joshcooper
Copy link
Contributor

Previously, we guarded requiring the hocon gem based on the feature, but
we never re-evaluated the feature, so you couldn't use the hocon module
in the same run that the hocon gem was installed.

This commit moves the requiring logic into the feature definition, and
confines the provider based on the hocon feature.

Previously, we guarded requiring the hocon gem based on the feature, but
we never re-evaluated the feature, so you couldn't use the hocon module
in the same run that the hocon gem was installed.

This commit moves the requiring logic into the feature definition, and
confines the provider based on the hocon feature.
@MSLilah
Copy link
Contributor

MSLilah commented Feb 5, 2016

👍

@joshcooper
Copy link
Contributor Author

FWIW, this is the puppet code I was using to test this PR. I'm running this using puppet as a gem, so the gem provider is using system ruby:

package { 'hocon':
  ensure          => present,
  install_options => ['--no-ri', '--no-rdoc'],
  provider        => gem,
}

hocon_setting { 'code-id-command':
  ensure  => present,
  path    => '/etc/puppetlabs/puppetserver/conf.d/puppetserver.conf',
  setting => 'versioned-code.code-id-command',
  value   => '/usr/local/bin/code_id.sh',
  require => [
    Package['hocon']
  ]
}

MSLilah pushed a commit that referenced this pull request Feb 10, 2016
(HC-46) Confine provider based on hocon feature
@MSLilah MSLilah merged commit 46bd9af into puppetlabs:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants