(HC-30) Make path and setting namevars #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the path and setting parameters namevars, thus ensuring that Puppet will give an error if two resources manage the same hocon setting in the same file.
|
Looks good to me 👍 |
|
This looks good and the tests are the behavior I would expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the path and setting parameters namevars, thus ensuring that
Puppet will give an error if two resources manage the same hocon
setting in the same file.
To implement this I ended up needing to make some changes to the API. This change should be compatible with all existing puppet code written using the
hocon_settingtype unless the user was explicitly settingname.When we release this change we should either release the module as 0.10.0 or 1.0.0.