(HC-91) Make tests compatible with newer ruby versions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, some of the spec tests were failing on Ruby 2.2 and newer. This was due to the fact that the way variable names are handled and scoped had changed, and we were unintentionally overloading a variable name. In order to fix this issue, change one of the variable names so they do not conflict.
|
This looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, some of the spec tests were failing on Ruby
2.2 and newer. This was due to the fact that the way variable names
are handled and scoped had changed, and we were unintentionally
overloading a variable name. In order to fix this issue, change
one of the variable names so they do not conflict.