(maint) Actually fix conditional statement #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conditoinal => conditional ? |
The previous commit contained an error. Unwrap 'puppet_version' in the first conditional statement, it should not be passed into Gem::Version.new().to_s first.
HAIL9000
force-pushed
the
maint/master/please_let_this_end
branch
from
d75896d
to
aaa6cd9
Compare
|
oops typo corrected @haus thanks for pointing it out |
haus
changed the title
|
Oh... thanks for fixing the PR title too! Sorry I missed that part 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit contained an error. Unwrap 'puppet_version' in
the first conditional statement, it should not be passed into
Gem::Version.new().to_s first.