Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msync] Add locales folder and config.yaml #60

Merged
merged 1 commit into from
Mar 27, 2017
Merged

[msync] Add locales folder and config.yaml #60

merged 1 commit into from
Mar 27, 2017

Conversation

wilson208
Copy link

No description provided.

@rlinehan
Copy link
Contributor

I feel like the content of the commit here doesn't match the commit title?? But maybe I don't understand.

@wilson208
Copy link
Author

@rlinehan You are correct, however as a result of MODULES-4528 I have needed to do a modulesync run to remove Puppet.version.to_f from the spec/spec_helper.rb file of most modules. However there were other pending modulesync changes as well as mine so these have been applied also in the msync run. However modulesync does not manage the spec/spec_helper.rb file of this module so only the other pending changes have been applied and no changes to spec_helper.rb and an msync run applies the same commit message to all modules.

@wilson208 wilson208 changed the title [MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb [msync] Add locales folder and config.yaml Mar 27, 2017
@pmcmaw pmcmaw merged commit 4dbd0ec into master Mar 27, 2017
@wilson208 wilson208 deleted the modules-4528 branch March 29, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants