Resolve config object before manipulating it #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magisus
force-pushed
the
resolve-config
branch
2 times, most recently
from
63a5d49
to
663ca88
Compare
The ConfigDocument API that preserves comments and formatting in HOCON files does not automatically resolve substitutions. This makes it impossible to manipulate settings that involve substitutions. This commit adds a `resolve` call to the config object that is parsed and provided for manipulation.
Magisus
force-pushed
the
resolve-config
branch
from
663ca88
to
91fefca
Compare
justinstoller
approved these changes
Oct 23, 2018
h0tw1r3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConfigDocument API that preserves comments and formatting in HOCON
files does not automatically resolve substitutions. This makes it
impossible to manipulate settings that involve substitutions. This
commit adds a
resolvecall to the config object that is parsed andprovided for manipulation.