Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CeentOS, RHEL, and OEL #90

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

trevor-vaughan
Copy link
Contributor

  • Add support for CentOS, RHEL, and OEL to metadata.json
  • Fix some errors in the CHANGELOG.md

* Add support for CentOS, RHEL, and OEL to metadata.json
* Fix some errors in the CHANGELOG.md
@david22swan
Copy link
Member

@trevor-vaughan Have you tested on these OS?? This is not a supported module so there is no pipeline for me to consult.

@trevor-vaughan
Copy link
Contributor Author

@david22swan Yes. We actively use it as part of the SIMP stack which runs on these operating systems.

@david22swan
Copy link
Member

@trevor-vaughan Ok, didn't notice this earlier, but any reason for you bumping the version number???

@trevor-vaughan
Copy link
Contributor Author

@david22swan I can switch it back, or you can push to the branch if you need to change it back. Just wanted to indicate that this has progressed beyond the last release.

@david22swan
Copy link
Member

@trevor-vaughan I'd prefer it if you could put it back please. Version bumps should only be done as part of the release cycle.

@david22swan
Copy link
Member

@trevor-vaughan Seeing as this is a docs only change and the error looks to come from a known problem system problem I'm gonna go ahead and merge this despite the failure. Thanks for putting in the work.

@david22swan david22swan merged commit a9a02f3 into puppetlabs:master Jan 14, 2019
@trevor-vaughan
Copy link
Contributor Author

@david22swan Appreciated!

@trevor-vaughan trevor-vaughan deleted the supported_os_update branch January 14, 2019 16:13
@michaeltlombardi michaeltlombardi changed the title Supported OS Update (MAINT) Add support for CeentOS, RHEL, and OEL Mar 17, 2020
@h0tw1r3 h0tw1r3 changed the title (MAINT) Add support for CeentOS, RHEL, and OEL Add support for CeentOS, RHEL, and OEL Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants