Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle quotation marks in section names #115

Merged
merged 7 commits into from
Jul 7, 2014
Merged

Handle quotation marks in section names #115

merged 7 commits into from
Jul 7, 2014

Commits on Jun 26, 2014

  1. be_true and be_false are deprecated

    Replace with `be true` and `be false` and make predicate return a
    boolean.
    
    > Methods that don't return a boolean, shouldn't end in a question mark.
    -- https://github.com/bbatsov/ruby-style-guide#naming
    johnsyweb committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    961447d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41fc8bf View commit details
    Browse the repository at this point in the history
  3. Handle quotation marks in section names

    The section name appears on a line by itself, in square brackets (`[` and
    `]`), all characters between the opening `[` and the closing `]` should
    be considered to form the section name.
    johnsyweb committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    49960e1 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'deprecation-warnings' into handle-quotation-marks-in-se…

    …ction-names
    
    This should fix the build.
    
    If this change isn't desired,
    ./spec/unit/puppet/provider/ini_setting/ruby_spec.rb:1044 could be
    changed to:
    
    ```ruby
    provider.exists?.should be_nil
    ```
    johnsyweb committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    cabc678 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2014

  1. Test allowing $ signs in section names

    Verifying that this PR addresses #98
    johnsyweb committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    bd99244 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2014

  1. Configuration menu
    Copy the full SHA
    069aa56 View commit details
    Browse the repository at this point in the history
  2. Spec for MODULES-1194

    Ini_file module does not recognize section names with forward slashes in them
    
    https://tickets.puppetlabs.com/browse/MODULES-1194
    johnsyweb committed Jul 4, 2014
    Configuration menu
    Copy the full SHA
    b3fed85 View commit details
    Browse the repository at this point in the history