add ensure=absent support #17
Conversation
This commit adds the ability to ensure that lines are absent.
|
@bodepd : just got back from vacation, will take a peek at this soon. |
|
@cprice-puppet please have a close look. I was guessing a little bit at how it should be implemented. |
|
@bodepd : are you implying that I don't always do that? :) I really did review your last one before I merged it! It was legit. I'll be careful on this one though, thanks for the heads up. |
| section = @sections_hash[name] | ||
|
|
||
| if section.start_line.nil? | ||
| fh.puts("\n[#{section.name}]") | ||
| elsif ! section.end_line.nil? | ||
| (section.start_line..section.end_line).each do |line_num| | ||
| fh.puts(lines[line_num]) | ||
| if lines[line_num] |
There was a problem hiding this comment.
I'm a little iffy on this part. @bodepd : I may open a new pull with another commit on top of this one.
There was a problem hiding this comment.
it was printing an extra nil at the end of the line b/c the line numbers related to the sections were not being recalculated. which resulted in an extra newline. I was not sure if there was something that I should have been calling to recalculate the line numbers.
There was a problem hiding this comment.
as an FYI, the inifile based native types for openstack have gotten great reception this week!
This commit adds the ability to ensure that lines are absent.
Chris, please double check this. I was a little confused by the fact that the file lines indices need to be updated and at first was seeing nils printed to the resulting file.