[MODULES-2369] Support a space as a key_val_separator #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, trying to use a space as a key_val_separator in the ini_setting type would fail because #strip is being called on the key_val_separator attribute, which completely kills the space. This commit checks to see if key_val_separator has been set as a space, and, if so, sets the `k_v_s` variable in the library to be ' ' instead of ''. This in turn allows the provider to check for existing values (instead of inserting the value every time Puppet is run).
glarizza
force-pushed
the
MODULES_2369_key_val_separator
branch
from
d369dd0
to
d452e6c
Compare
jonnytdevops
added a commit
that referenced
this pull request
Aug 7, 2015
[MODULES-2369] Support a space as a key_val_separator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, trying to use a space as a key_val_separator in the ini_setting
type would fail because #strip is being called on the key_val_separator
attribute, which completely kills the space. This commit checks to see
if key_val_separator has been set as a space, and, if so, sets the
k_v_svariable in the library to be ' ' instead of ''. This in turn allows the
provider to check for existing values (instead of inserting the value every
time Puppet is run).