Adding path to create_ini_settings resources #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2015 18:00
Currently the create_ini_settings function creates an ini_setting with a title comprised of the section and setting names. This means that we run into resource conflicts when defining the same section/setting combinations but in different files. Since the path parameter is required, we can safely add this to the title of the ini_setting resource created by the create_ini_settings function. This commit does just that.
…file into create_ini_settings_namespace
|
👍 this is essential for creating more than one ini file with a common section and setting. |
hunner
added a commit
that referenced
this pull request
Aug 26, 2015
Adding path to create_ini_settings resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
create_ini_settingsfunction creates anini_settingresource with a title comprised of thesectionandsettingvalues. This means that we run into resource conflicts when defining the same section/setting combinations but in different files. Since thepathparameter is required, we can safely add this to the title of theini_settingresource created by thecreate_ini_settingsfunction. This commit does just that.