Handle backwards compatibility with force_new_section_creation #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhahaha
force-pushed
the
bug/1778247
branch
2 times, most recently
from
0c39024
to
1159317
Compare
hsitin
suggested changes
Jun 26, 2018
|
Is there an alternative function to use to see if a param is on a type? |
Prior to the introduction of this new parameter in the ini_setting type, a user may have had their own custom type which implemented the required parameters. The introduction of this new type would break anyone who was not inheriting from the provide ini_setting type. This change adds a check before looking for this option to allow those users to continue to work. If the force_new_section_creation is not defined on the type, the previous expected functionality of automatic creation of the section will occur. Related-Bug: https://bugs.launchpad.net/puppet-openstacklib/+bug/1778247
|
@hsitin, @david22swan please retest this version, I think this will work correctly now |
|
Passed on adhoc |
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Jul 3, 2018
This reverts commit f8648b2. puppetlabs/puppetlabs-inifile#288 has been merged to allow for backwards compatibility. Change-Id: I52673b6a8524ce0fe33df6c08f1aa6e058524b51 Closes-Bug: LP#1778247
|
Hey! @hsitin I am going to cut a release of inifile, just want to ensure that you are happy enough that the changes have resolved the issue you were seeing regarding resource.respond_to?(:force_new_section_creation) always returning False. Many Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the introduction of this new parameter in the ini_setting type,
a user may have had their own custom type which implemented the required
parameters. The introduction of this new type would break anyone who was
not inheriting from the provide ini_setting type. This change adds a
check before looking for this option to allow those users to continue to
work. If the force_new_section_creation is not defined on the type, the
previous expected functionality of automatic creation of the section
will occur.
Related-Bug: https://bugs.launchpad.net/puppet-openstacklib/+bug/1778247