Properly handle empty values #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a legitimate use case to set empty values; to override a default when an empty value is acceptable for instance. This patch changes the regex in three ways: it 1) removes the requirement for a non-whitespace terminator on a setting value, 2) makes the value match non-greedy so that the \s*$ at the end can catch the newline and 3) changes the \s*=\s* to [ \t]*=[ \t]* because we don't want that to capture *any* whitespace (like a newline).
|
This is the second pull request that has come in for this type of feature, so there's obviously demand for it. We'll get it in ASAP. |
|
Yeah, I looked at mgagne's as well and tried to address the issue that he found in his patch and to add more tests, since that seemed to be one of the hold ups. |
|
We're working on stealing this module from cprice and taking it over within puppetlabs. As a result I copied this PR over to #1 and then merged it. |
|
(I take it back, we're going to work on transferring this over so we don't lose attribution for all your PRs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a legitimate use case to set empty values; to override a
default when an empty value is acceptable for instance. This patch
changes the regex in three ways: it 1) removes the requirement for
a non-whitespace terminator on a setting value, 2) makes the value
match non-greedy so that the \s_$ at the end can catch the newline
and 3) changes the \s_=\s* to [ \t]=[ \t] because we don't want
that to capture any whitespace (like a newline).