Add support for official Oracle Java SE jdk and jre packages for CentOS #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,7 @@ | |||
| } | |||
| ], | |||
| "dependencies": [ | |||
| {"name":"puppetlabs/stdlib","version_requirement":">= 2.4.0 < 5.0.0"} | |||
| {"name":"puppetlabs/stdlib","version_requirement":">= 2.4.0 < 5.0.0"}, | |||
| {"name":"puppet-community/puppet-archive","version_requirement":"0.3.0"} | |||
There was a problem hiding this comment.
Adding this dependency would be backwards incompatible, and not needed if users are not using java::oracle, so perhaps it should just be documented as an optional dependency for when using java::oracle instead of a hard dependency.
There was a problem hiding this comment.
Oh, and the forge namespace is just puppet
|
Thanks! Would you mind updating the readme reference section for java::oracle and mentioning that it needs archive? |
…as dependency since it is only required for java::oracle.
|
Thanks for the feedback @hunner. I updated the README and removed the hard dependency. |
hunner
added a commit
that referenced
this pull request
Mar 2, 2016
Add support for official Oracle Java SE jdk and jre packages for CentOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I fixed my code for Oracle Java SE support on CentOS. Could you please review?