replace validate_* calls with datatypes & minor fixes #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
puppet4
branch
2 times, most recently
from
9b532c3
to
e7e8279
Compare
jbondpdx
suggested changes
Jun 7, 2017
|
@jbondpdx updated it. |
|
Awesome, thank you. I get your logic in changing it, but consistency. |
binford2k
requested changes
Jun 7, 2017
manifests/init.pp
Outdated
| Pattern[/present|installed|latest|^[.+_0-9a-zA-Z:~-]+$/] $version = 'present', | ||
| $package = undef, | ||
| Optional[Array] $package_options = undef, | ||
| $java_alternative = undef, |
There was a problem hiding this comment.
Shouldn't these be Optional[String]?
There was a problem hiding this comment.
The goal was to replace all the validate_* calls with datatypes, not to add datatypes to all parameters. I normally mention this, but somehow forgot it here. I added datatypes to all params in init.pp now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.