Add Java alternatives for RHEL based distros. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhaskel ping. Any word on this? Anything else needed for this commit to be acceptable? |
|
Hi @brdude. Sorry for the delay in getting back to you. For the test updates, I meant an update in |
|
HI @mhaskel. Hopefully the rspec test I added is sufficient as this is the first time I've used it I'm not entirely sure how to gauge it. If you end up needing more test please let me know and I'll be more then happy to do so. |
|
@mhaskel Sounds good. The files .travis.yml, Rakefile, Gemfile, and .puppet-lint.rc have been removed from the commit. And the commits have been squashed into a single one. The Travis checks should go back to passing once #93 has been merged as well. |
underscorgan
pushed a commit
that referenced
this pull request
Dec 26, 2014
Add Java alternatives for RHEL based distros.
|
Great, thanks @brdude ! |
underscorgan
pushed a commit
to underscorgan/puppetlabs-java
that referenced
this pull request
Dec 29, 2014
Alternatives support was added in puppetlabs#89, but the test wasn't updated to expect failures when invalid alternatives are passed to RHEL systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to pull request #61.
The code was contributed by @dstockman on the PR referenced above.
The reason I did not include the java alternative updates in java::params is because the default RPM packages for openJDK automatically set the java alternatives when installed. The only time this would be used is when installing an alternative package suck as Oracle Java.
@mhaskel