(maint) Remove ruby requirement for creating certs #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyberious
commented
Aug 19, 2015
cyberious
commented
- Add install_ca_certs for windows
- Install from forge instead of git
| @@ -1,34 +1,26 @@ | |||
| require 'beaker-rspec/spec_helper' | |||
| require 'beaker-rspec/helpers/serverspec' | |||
| require 'beaker/puppet_install_helper' | |||
| require 'pry' | |||
There was a problem hiding this comment.
Does pry need to be in the Gemfile ?
- Add install_ca_certs for windows platforms - Install from forge instead of git - Increases ability to test across older versions of windows - No longer needs to search for ruby to generate pem files
| @@ -28,7 +28,7 @@ group :system_tests do | |||
| gem 'beaker-rspec', :require => false | |||
| end | |||
| gem 'serverspec', :require => false | |||
| gem 'beaker-puppet_install_helper', :require => false | |||
| gem 'beaker-puppet_install_helper', '~> 0.3', :require => false | |||
There was a problem hiding this comment.
Does this need to be bound this tightly?
There was a problem hiding this comment.
it needs to be at least 0.3 as that is when we added install_ca_certs
There was a problem hiding this comment.
Yes, but seems like >= 0.3.0 would cause fewer future issues.
There was a problem hiding this comment.
More so it protects us from what may happen in 1.0 but anything up until 1.0
underscorgan
pushed a commit
that referenced
this pull request
Aug 19, 2015
(maint) Remove ruby requirement for creating certs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.