Support EC keys #162
Merged
Support EC keys #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new parameter "private_key_type" which defaults to "rsa" but can also be set to "ec" for ECDSA keys. Contains updated README and some spec tests for the type. Due to various bugs in ruby-openssl it is currently difficult to properly test EC keys (https://bugs.ruby-lang.org/issues/12348, ruby/openssl#29).
|
This looks really good, readme tests and easy to follow. Great PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter "private_key_type" which defaults to "rsa" but can
also be set to "ec" for ECDSA keys.
Contains updated README and some spec tests for the type. Due to various
bugs in ruby-openssl it is currently difficult to properly test EC keys
(https://bugs.ruby-lang.org/issues/12348, ruby/openssl#29).