fix java install on windows in acceptance #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes installing java on windows in the acceptance tests by moving the installation logic to the spec_helper_acceptance so that java is always installed when needed, and removes basic_spec.rb because having the installation logic in one spec file means all spec files must be run in order to have a properly setup environment. This commit also migrates the java install from using windows_java to puppetlabs-chocolatey. This follows a standard at Puppet to use chocolatey in acceptance to setup an environment.
This commit fixes the path to java because the jdk package installed by chocolatey uses 'C:\Program Files' instead of a custom path. The spaces cause errors, so we properly quote them in order for the command to work.
jpogran
approved these changes
Jul 11, 2017
This commit refactors OS specific parameters to be more maintainable. Instead if have many case statements, a common target and target_dir is used.
glennsarti
force-pushed
the
jpogran-MODULES-5117-fix-java-install-on-windows-in-acceptance
branch
from
b5b6b01
to
1302a80
Compare
|
This supercedes #185 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.