(FM-6457) Fix Windows CI #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the acceptance tests installed JDK from the chocolatey package repo and pinned the version to `8.0.144`; however, that package now fails to install due to a 404 error in the download. This commit updates the version pin to `8.0.152`, which is the latest stable release and which installs correctly.
The shell string in the it block of the pkcs12 acceptance tests does not include escaped quoting around the path to `keytool` prior to this commit. This causes a failure on windows because the path includes a space. This commit wraps the path to keytool in escaped quotes to resolve the issue.
|
@michaeltlombardi just to let you know I closed and reopened your PR to enable Appveyor. |
michaeltlombardi
changed the title
|
@pmcmaw: Looks like the Appveyor build is broken due to configuration? |
|
@michaeltlombardi Ive rekicked it. I enabled it without the configuration, it should start looking better in a few mins |
|
Awesome, thank you! |
|
No problem thats it now :-) |
|
Looks like the appveyor build is failing because it's trying to use nixy paths on Windows. :( |
Prior to this commit, the unit tests for java_ks could never pass on windows due to use of linux paths and commands hard-coded. This commit adds a variable for the temp paths in both spec test files and guards against running tests that rely on linux commands on a windows machine.
|
@pmcmaw: All tests are green now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix problems with CI for Windows.