Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop Implemented #212

Merged
merged 1 commit into from Jan 11, 2018
Merged

Rubocop Implemented #212

merged 1 commit into from Jan 11, 2018

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan changed the title Rubocop Tracking Commit (WIP) Rubocop Implemented Jan 10, 2018
eputnam
eputnam requested changes Jan 11, 2018
View reviewed changes
lib/puppet/provider/java_ks/keytool.rb Outdated
end

def get_password
def password?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically a question mark denotes a boolean method but this returns a string. maybe nix the question mark.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@eputnam eputnam merged commit 6b640cc into puppetlabs:master Jan 11, 2018
@david22swan david22swan deleted the Rubocop branch January 18, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eputnam eputnam eputnam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david22swan @eputnam