Use better raise syntax to suppress compatibility warnings.
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby Enterprise (ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux], MBARI
0x6770, Ruby Enterprise Edition 2009.10) complains about the `raise` lines in
the java_ks provider:
/var/lib/puppet/lib/puppet/provider/java_ks/keytool.rb:130: warning: parenthesize argument(s) for future version
Adding a comma here suppresses the warning and seems to be more in line with
Ruby community conventions.
hunner
added a commit
that referenced
this pull request
Sep 18, 2013
Use better `raise` syntax to suppress compatibility warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby Enterprise (ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux], MBARI 0x6770, Ruby Enterprise Edition 2009.10) complains about the
raiselines in the java_ks provider:Adding a comma here suppresses the warning and seems to be more in line with Ruby community conventions.
(Neither version of this change cause problems in 1.8.9.)