Make it all work on solaris... #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| require 'spec_helper_acceptance' | |||
|
|
|||
| describe 'prep nodes', :unless => UNSUPPORTED_PLATFORMS.include?(fact('operatingsystem')) do | |||
| it 'requires java' do | |||
| it 'requires java', :unless => fact('osfamily') == "Solaris" do | |||
There was a problem hiding this comment.
This probably isn't necessary, Solaris shouldn't be in the UNSUPPORTED_PLATFORMS list
There was a problem hiding this comment.
It isn't. It's just excluded from the "requires java" part :)
There was a problem hiding this comment.
"It requires java unless the osfamily is solaris"
There was a problem hiding this comment.
Ohhh, we're in basic. I thought we were in unsupported. My bad
There was a problem hiding this comment.
This also answers my next question: "Where do we install java"
branan
pushed a commit
that referenced
this pull request
Feb 28, 2014
Make it all work on solaris...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.