Stop depending on puppet certs to test java_ks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we removed the call to `puppet master` during acceptance testing setup because it caused conflicts in agent-master multinode setups. However, we realized that the reason for the call to `puppet master` in the first place was so that java_ks could use the existing puppet certs that exist on the puppet master. This patch refactors the tests to generate a CA and private key itself. This avoids having tests depend on a certain node configuration. It also adds /usr/bin to the PATH on solaris so that the java_ks type can use the openssl command in tests on solaris.
hunner
added a commit
that referenced
this pull request
Oct 8, 2014
Stop depending on puppet certs to test java_ks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we removed the call to
puppet masterduring acceptancetesting setup because it caused conflicts in agent-master multinode
setups. However, we realized that the reason for the call to
puppet masterin the first place was so that java_ks could use the existingpuppet certs that exist on the puppet master. This patch refactors the
tests to generate a CA and private key itself. This avoids having tests
depend on a certain node configuration.
The alternative is to put the call to
puppet masterback andconditionally detect whether the master is already daemonized.
However I think separating the puppet setup from the testing '
environment is a better solution.
It also adds /usr/bin to the PATH on solaris so that the java_ks type
can use the openssl command in tests on solaris.