Add tests for windows and remove usage of OPENSSL to check MD5 as keytool has that capability #91
Conversation
…tool has that capability Conflicts: spec/acceptance/keystore_spec.rb spec/acceptance/private_key_spec.rb spec/acceptance/truststore_spec.rb spec/spec_helper_acceptance.rb
|
Do not merge yet!!! Some in flight changes now to remove openssl as a tool entirely |
|
|
||
| #install java if windows | ||
| if host['platform'] =~ /windows/i | ||
| on host, 'powershell.exe -command "(New-Object System.Net.Webclient).DownloadString(\'https://forge.puppetlabs.com\')"' |
There was a problem hiding this comment.
This should be handled as an acceptance setup step. The problem is the test forge instance is using a new CA cert that is issued by neither GeoTrust nor Gandi, see https://tickets.puppetlabs.com/browse/OPS-4555
There was a problem hiding this comment.
This has nothing to do with test forge and is a problem against production Forge. It is apparently a known issue that you must first invoke a web request before so that the trust certs are updated in the Windows cert store.
--
Travis Fields
Forge Module Engineer
On Mon, Oct 13, 2014 at 1:15 PM, Josh Cooper notifications@github.com
wrote:
on host, "PATH=#{path} ruby -e \"#{opensslscript}\""
#install java if windowsif host['platform'] =~ /windows/ion host, 'powershell.exe -command "(New-Object System.Net.Webclient).DownloadString(\'https://forge.puppetlabs.com\')"'This should be handled as an acceptance setup step. The problem is the test forge instance is using a new CA cert that is issued by neither GeoTrust nor Gandi, see https://tickets.puppetlabs.com/browse/OPS-4555
Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/puppetlabs-java_ks/pull/91/files#r18792070
|
If/when this is merged we will need to update CI to set the install source to the location referenced in QE-1369 |
|
Yes, I believe we will do this with an environment variable. |
…plify the test layout
Conflicts: lib/puppet/provider/java_ks/keytool.rb spec/acceptance/keystore_spec.rb spec/acceptance/private_key_spec.rb spec/acceptance/truststore_spec.rb spec/spec_helper_acceptance.rb
cyberious
force-pushed
the
WindowsTesting
branch
4 times, most recently
from
3bf9861
to
d6071d6
Compare
|
@cmurphy @justinstoller what are your thoughts now. Justin I have added a JAVA_VERSION variable which expects a pattern of (MAJ)u(MINOR) which is how Java does it as well, we then split this, also there is a JAVA_DOWNLOAD_SOURCE env variable that will allow an alternate download site to eat less bandwidth and speed up the test. |
| end | ||
| # def command_openssl | ||
| # 'openssl' | ||
| # end |
There was a problem hiding this comment.
Could you delete this instead of commenting?
cyberious
force-pushed
the
WindowsTesting
branch
from
d6071d6
to
dd031b2
Compare
Add tests for windows and remove usage of OPENSSL to check MD5 as keytool has that capability
Add acceptance tests for CHAIN certs.
Refactor to have less duplication using include_context