Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support repo parameters #96

Closed
micah opened this issue Apr 17, 2018 · 3 comments
Closed

Support repo parameters #96

micah opened this issue Apr 17, 2018 · 3 comments
Assignees
@scotty-c
Labels
needs-tests

Comments

@micah
Copy link

micah commented Apr 17, 2018

It would be nice if the apt source repos could be parameterized, instead of being hard-coded.

On a Debian stretch machine, it doesn't make so much sense to use the release kubernetes-xenial when it should instead be kubernetes-stretch, nor does it make sense to use the ubuntu-xenail release for the docker apt source, when there is a debian-stretch one.
@scotty-c
Copy link
Contributor

@micah We are only supporting Ubuntu officially in this module. More than happy to look at a PR to add support for Debian

@scotty-c scotty-c self-assigned this Apr 17, 2018
@KlavsKlavsen
Copy link
Contributor

Ubuntu-bionic would also be nice..

@davejrt
Copy link
Contributor

davejrt commented Jul 24, 2018

@KlavsKlavsen these parameters have been exposed in PR #133

@davejrt davejrt closed this as completed Jul 24, 2018
lionce added a commit to lionce/puppetlabs-kubernetes that referenced this issue Dec 19, 2019
@lionce
Merge pull request puppetlabs#96 from puppetlabs/fix-mm-format
cc3301d 
(maint) Fix incorrect formatting in managed_modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scotty-c scotty-c

Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@micah @davejrt @KlavsKlavsen @scotty-c