Fix cloud_provider hostnames #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make node_name mandatory for init/join, as the execs won't work without it
jorhett
force-pushed
the
fix_aws_hostnames
branch
from
3587b26
to
a20b4cc
Compare
|
Thanks for your contribution. The use of a single paramater was what I was referring to earlier when I said that was our error and we should have remedied it, but we appreciate your effort in going ahead and raising this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there's some inconsistency between cloud providers which mandate that their metadata names for the node be used (notably but not only AWS) and the usage of the node label in various
execresources.This change makes the internal name passed around be
node_name, and allows us to query the metadata of a cloud provider when necessary to determine the appropriate name. It defaults to the original behavior of using the fact's hostname.This seemed easier than trying to hot-query k8s during installation to determine what name it wants us to use. In AWS's case, this might go away if these changes ever land: kubernetes/kubernetes#61878
fixes #218
obsoletes #221