(MAINT) Revert hardening changes #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes::kube_addons is a classthat may have no external impact to Forge modules. kubernetes::kubeadm_init is a typethat may have no external impact to Forge modules. kubernetes::kubeadm_join is a typethat may have no external impact to Forge modules. kubernetes::packages is a classthat may have no external impact to Forge modules. kubernetes::service is a classthat may have no external impact to Forge modules. kubernetes::wait_for_default_sa is a typethat may have no external impact to Forge modules. This module is declared in 0 of 580 indexed public
|
chelnak
force-pushed
the
maint-revert_hardening_changes
branch
2 times, most recently
from
5b4828a
to
e11b332
Compare
chelnak
force-pushed
the
maint-revert_hardening_changes
branch
from
e11b332
to
cb74fc4
Compare
This commit builds on the work that @deric submitted in a previous pr. In a few other manifests there were variables set that added no value. They have been reduced back to literal entries in the exec resources. This commit applies those changes to this PR to keep things consistent.
chelnak
force-pushed
the
maint-revert_hardening_changes
branch
from
d6078cd
to
fe6c101
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a few discrepancies left over from the hardening work.
Along with the work from @deric , the work here should help towards returning main back to a green state.