add minor device no and persist options #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| newparam(:minor) do | ||
| desc "Set the minor number" | ||
| validate do |value| | ||
| unless value =~ /^(?:[0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])$/ |
There was a problem hiding this comment.
How about if value.to_i > 255 or value.to_i < 0 instead of a regex
There was a problem hiding this comment.
It's a fair cop, guv.
|
A couple notes:
|
Changes following comments on original pull request
robinbowes
force-pushed
the
feature/add_minor_device_no_and_persist_options
branch
from
5500ea6
to
49faba3
Compare
|
Updated to address @hunner's comment, and @bmjen's 2nd point. Regarding the README, I'd be happy to add the new params and some examples to the README if it were in some sort of sane format that made that relatively easy. However, it seems to me that the README needs a complete overhaul to bring it into line with the recommended standard layout. I think that is out of the scope of this PR. |
bmjen
added a commit
that referenced
this pull request
Sep 3, 2015
…sist_options add minor device no and persist options
|
Thi issue should be closed rigth https://tickets.puppetlabs.com/browse/MODULES-2261? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to create LVs with persistent block device IDs (for use a ext4 journal devices)
This change surfaces the --persistence and --minor options to the lvcreate command.