Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfs online resizing support #40

Merged
merged 1 commit into from Sep 14, 2013

Conversation

sgzijl
Copy link

@sgzijl sgzijl commented Sep 14, 2013

Added new feature xfs online resizing. Last PR didn't pass test (blkid invoked twice, expected once), which seems to be fixed now (locally).

apenney pushed a commit that referenced this pull request Sep 14, 2013
@apenney apenney merged commit 4287f0b into puppetlabs:master Sep 14, 2013
@sgzijl sgzijl deleted the feature-add_xfs_online_resize branch September 16, 2013 12:45
@c33s
Copy link

c33s commented Oct 2, 2013

there is a major problem with this commit, the commands for creating and changing an xfs filesystem work different:

mkfs.xfs <device>
xfs_growfs <mount-point>

mkfs.xfs requires a device like /dev/vg_group/mytest and xfs_growfs requires a mount point like /mnt/mytest

so if a filesystem is defined like that (device):

filesystem { "/dev/vg_group/mytest": ensure => present, fs_type => 'xfs' }

mkfs.xfs works but xfs_growfs fails with the message xfs_growfs: /dev/vg_group/mytest is not a mounted XFS filesystem

defining the filesystem as mount point:

filesystem { "/mnt/mytest": ensure => present, fs_type => 'xfs' }

mkfs.xfs fails with mkfs.xfs /mnt/mytest' returned 1: /mnt/mytest: No such file or directory

@sgzijl
Copy link
Author

sgzijl commented Oct 12, 2013

@c33s are you trying to resize an unmounted xfs filesystem? with xfs resizing only works on mounted filesystems. it doesn't matter whether you specify the device or mount point (tested on Centos6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants