Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update PDK template #44

Merged
merged 5 commits into from Apr 10, 2023

Conversation

mhashizume
Copy link
Contributor

This PR:

  • Updates the PDK template to 2.7.4.
  • Sets metadata.json to allow Puppet versions < 9.0.0 in preparation for the release of Puppet 8.
  • Updates GitHub Actions runners from Ubuntu 18.04 to 20.04, from macOS 10.15 to 11, and actions/checkout from v2 to v3.

This commit runs `pdk update` using the most recent template at the
time (2.7.4) and updates metadata.json to allow Puppet versions
< 9.0.0 in preparation for the release of Puppet 8.
This commit updates GitHub Actions to move away from both operating
systems and Actions that are nearing or past end-of-life.
The PDK Docker image does not contain any build tools, which causes
the installation of gems that use native extensions to fail.

This commit changes the Docker image used in the Auto Release
GitHub Action from the PDK image to the Puppet dev-tools image,
which contains packages like `make` necessary for building native
extensions.
In e4337c0, we updated the module according to PDK template 2.7.4,
which updated puppetlabs_spec_helper. The updated version of
puppetlabs_spec_helper removed the Beaker rake task, which we use
for acceptance testing.

This commit adds the voxpupuli-acceptance gem, which re-adds the
Beaker rake task.
Modeling after the learnings of the support team in commit
puppetlabs/puppetlabs-puppet_metrics_collector@78dd858

This commit pins the github_changelog_generator gem to its latest
version to make it work, and the concurrent-ruby to an older version
to compensate for the version of PDK shipped in the dev-tools
container image.
@mhashizume mhashizume requested a review from a team as a code owner April 10, 2023 17:22
@AriaXLi AriaXLi merged commit 278ca98 into puppetlabs:main Apr 10, 2023
14 checks passed
@mhashizume mhashizume deleted the maint/main/pdk-update branch April 10, 2023 18:47
@mhashizume mhashizume added the enhancement New feature or request label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants