Make mongodb_conn_validator namevar the URI to check #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently one needs to pass server and port parameters for each node
s/he wants to test if mongodb is up and running. Admiting we have an
array of nodes there is no easy way to check all of them.
By allowing the name of the resource as the connection to test, this
scenario can be easily dealt with.
```
$array_of_mongo_nodes = ['ip1:27017', 'ip2:27017', '[::1]:27017']
mongodb_conn_validator { $array_of_mongo_nodes : }
```
Spredzy
force-pushed
the
conn_string_namevar_validator
branch
from
ce6befc
to
7d8e3c3
Compare
openstack-gerrit
pushed a commit
to stackforge/puppet-openstack-cloud
that referenced
this pull request
May 8, 2015
Stop to require MongoDB validation (this provider requies MongoDB working on the same node) so we can install MongoDB nodes outside Telemetry Collector service. This patch is a workaround until: voxpupuli/puppet-mongodb#200 is merged so we can use the code in this module. See https://review.openstack.org/179824 Change-Id: I80b102c3801efea262e6572fce1f64eb8a9a67ad
hunner
added a commit
that referenced
this pull request
May 22, 2015
Make mongodb_conn_validator namevar the URI to check
pkasprzak
pushed a commit
to gwdg/puppet-openstack-cloud
that referenced
this pull request
Jun 3, 2015
Stop to require MongoDB validation (this provider requies MongoDB working on the same node) so we can install MongoDB nodes outside Telemetry Collector service. This patch is a workaround until: voxpupuli/puppet-mongodb#200 is merged so we can use the code in this module. See https://review.openstack.org/179824 Change-Id: I80b102c3801efea262e6572fce1f64eb8a9a67ad
openstack-gerrit
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this pull request
Jun 8, 2015
Two PR have been merged upstream that let use improve our current implementation : * service_manage[1] * conn string has namevar[2] [1] voxpupuli/puppet-mongodb#198 [2] voxpupuli/puppet-mongodb#200 Change-Id: Ia2247348a9e0292b5fcbc65ea1e41e6bc7c477fa
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 8, 2015
Project: openstack/tripleo-heat-templates b00bae6c5a48ef9ac59b292f7bc67cf48395fb5e Update mongodb implementation to reflect master Two PR have been merged upstream that let use improve our current implementation : * service_manage[1] * conn string has namevar[2] [1] voxpupuli/puppet-mongodb#198 [2] voxpupuli/puppet-mongodb#200 Change-Id: Ia2247348a9e0292b5fcbc65ea1e41e6bc7c477fa
cegeka-jenkins
pushed a commit
to cegeka/puppet-mongodb
that referenced
this pull request
Oct 23, 2017
…lidator Make mongodb_conn_validator namevar the URI to check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one needs to pass server and port parameters for each node
s/he wants to test if mongodb is up and running. Admiting we have an
array of nodes there is no easy way to check all of them.
By allowing the name of the resource as the connection to test, this
scenario can be easily dealt with.