(FM-3924) Create Master/Agent automation test for Puppetlabs-motd #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is there so many Beaker host files included? I feel like we could use a much smaller subset. |
| @@ -0,0 +1,15 @@ | |||
| require 'master_manipulator' | |||
| test_name 'FM-3804 - C61700 - Install Puppet Enterprise' | |||
There was a problem hiding this comment.
The FM-3804 ticket referenced here is associated with Websphere.
|
You should add a README for the tests folder with some information about running the tests. Especially given the fact that the tests are only runnable inside Puppet Labs. Here is an example from DSC: https://github.com/puppetlabs/puppetlabs-dsc/tree/master/tests |
|
|
||
| # Init | ||
| step 'Install PE' | ||
| install_pe |
There was a problem hiding this comment.
There is no requirement that PE be used for the master. You could use the FOSS stuff instead.
phongdly
changed the title
phongdly
changed the title
phongdly
changed the title
phongdly
force-pushed
the
FM-3918/start_qa_review_of_puppetlabs-motd_module
branch
2 times, most recently
from
a9e7217
to
7805160
Compare
phongdly
force-pushed
the
FM-3918/start_qa_review_of_puppetlabs-motd_module
branch
from
7805160
to
2600a9e
Compare
| else | ||
| gem 'beaker-rspec', :require => false | ||
| end | ||
| gem 'serverspec', :require => false |
There was a problem hiding this comment.
You have duplicate entry for "serverspec". Only specify the dependency one time.
cowofevil
pushed a commit
that referenced
this pull request
Dec 15, 2015
…tlabs-motd_module (FM-3924) Create Master/Agent automation test for Puppetlabs-motd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has one test case of creating /etc/motd file using content parameter, the test case is located at puppetlabs-motd/tests/beaker/tests/01_create_motd_content.rb
The PR also uses Test Organization in Module Repositories as specified in https://confluence.puppetlabs.com/pages/viewpage.action?spaceKey=ENG&title=Test+Tiering+for+the+Modules+Team document written by @cowofevil