Skip to content

Commit

Permalink
Fixed server package name so it isn't hardcoded to mysql
Browse files Browse the repository at this point in the history
  • Loading branch information
slalomzacharyd authored and igalic committed May 27, 2015
1 parent 18e45a0 commit 4bab65e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions manifests/server/installdb.pp
Expand Up @@ -11,16 +11,15 @@

if $mysql::server::manage_config_file {
$install_db_args = "--basedir=${basedir} --defaults-extra-file=${config_file} --datadir=${datadir} --user=${mysqluser}"
} else {
$install_db_args = "--basedir=${basedir} --datadir=${datadir} --user=${mysqluser}"

}

exec { 'mysql_install_db':
command => "mysql_install_db ${install_db_args}",
creates => "${datadir}/mysql",
logoutput => on_failure,
path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin',
require => Package['mysql-server'],
require => Package[$mysql::server::package_name],
}

if $mysql::server::restart {
Expand Down
2 changes: 1 addition & 1 deletion manifests/server/service.pp
Expand Up @@ -31,7 +31,7 @@
name => $mysql::server::service_name,
enable => $mysql::server::real_service_enabled,
provider => $mysql::server::service_provider,
require => Package['mysql-server'],
require => Package[$mysql::server::service_name],

This comment has been minimized.

Copy link
@j-russell

j-russell May 27, 2015

This should be $mysql::server::package_name

This comment has been minimized.

Copy link
@igalic

igalic May 27, 2015

Contributor

awesome. how'd i miss that?
also, thanks for the catch.

This comment has been minimized.

Copy link
@igalic

igalic May 27, 2015

Contributor
}

# only establish ordering between config file and service if
Expand Down

0 comments on commit 4bab65e

Please sign in to comment.