Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify $backupdir as a symlink target, for use with dm… #1200

Merged
merged 4 commits into from Jun 4, 2019
Merged

Conversation

comport3
Copy link
Contributor

…_crypt encrypted partitions.

@tphoney
Copy link
Contributor

tphoney commented May 31, 2019

Thanks for the PR, @comport3 . Could you add to the documentation, about this great new functionality.
optional, squash your commits

@comport3
Copy link
Contributor Author

comport3 commented Jun 4, 2019

Yes of course. Is the correct file to do this in the CHANGELOG.md ?

Otherwise, here's the new functionality -

Within the class mysql::backup::mysqldump, there is now the ability to change the default behaviour of backing up to a 'directory' to a 'symlink' instead.

The specific use case it solved for us was to ensure backups were stored on a LUKS/DM Crypt based encrypted partition, but could also be handy for environments using NFS shared and similar redirection.

Usage (Hiera)

mysql::backup::mysqldump::mysqlbackupdir_ensure: link
mysql::backup::mysqldump::mysqlbackupdir_target: /mnt/mysqldumps

@tphoney
Copy link
Contributor

tphoney commented Jun 4, 2019

Normally it would go into the top of the file. But because this is a private class, there is no docs in the file. For this to be useful for all users, https://github.com/puppetlabs/puppetlabs-mysql/blob/master/manifests/server/backup.pp should be updated to include these new parameters. As it would be useful for all of the backup providers.

@tphoney tphoney merged commit 6ab951f into puppetlabs:master Jun 4, 2019
@tphoney
Copy link
Contributor

tphoney commented Jun 4, 2019

Thanks for the pr @comport3 :)

@eimlav eimlav added the feature label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants